-
Notifications
You must be signed in to change notification settings - Fork 25
Description
@anncheng-arm and I found an issue related to PCIe legacy interrupt tests.
The tests for PCI_LI_02, PCI_LI_01, PCI_LI_03, rely on pal_pcie_get_legacy_irq_map(). That means running the tests requires implementing the function pal_pcie_get_legacy_irq_map() and re-building the image.
For now, if a system has a PCIe device supporting Legacy interrupt but user doesn't implement the pal_pcie_get_legacy_irq_map(), the test will result in SKIPPED and show the message below:
- pal_pcie_get_legacy_irq_map unimplemented. Skipping test. The API is platform specific and needs to be populated by partners with system legacy irq map.
This result state is not clear enough. Also, showing SKIPPED as the test result is wrong if the system supports Legacy interrupts. The tests should result in WARNING, and we can improve the message to "The test is based on a conditional requirement. If the system supports Legacy interrupts, please populate the platform specific API (pal_pcie_get_legacy_irq_map) with system's legacy irq map or conduct a paper-based analysis for the compliance check".